-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added argument check and corresponding node runner test for the get_shape method #23637
Merged
almilosz
merged 7 commits into
openvinotoolkit:master
from
adismort14:get_shape_argument_check
Apr 17, 2024
Merged
Added argument check and corresponding node runner test for the get_shape method #23637
almilosz
merged 7 commits into
openvinotoolkit:master
from
adismort14:get_shape_argument_check
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almilosz
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that PR includes all applied changes
I have resolved both the comments in the latest commit. Kindly review it. |
almilosz
approved these changes
Mar 28, 2024
build_jenkins |
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
…hape method (openvinotoolkit#23637) This Fixes openvinotoolkit#23441 issue. Details: 1. Modified get_shape() method to report error in case any argument is passed. 2. Added Required Tests for the above in `tensor.test.js`. --------- Co-authored-by: Vishniakov Nikolai <[email protected]> Co-authored-by: Alicja Miloszewska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes #23441 issue.
Details:
tensor.test.js
.