Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added argument check and corresponding node runner test for the get_shape method #23637

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

adismort14
Copy link
Contributor

This Fixes #23441 issue.

Details:

  1. Modified get_shape() method to report error in case any argument is passed.
  2. Added Required Tests for the above in tensor.test.js.

@adismort14 adismort14 requested a review from a team as a code owner March 23, 2024 20:41
@github-actions github-actions bot added the category: JS API OpenVino JS API Bindings label Mar 23, 2024
Copy link
Contributor

@almilosz almilosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that PR includes all applied changes

src/bindings/js/node/src/tensor.cpp Outdated Show resolved Hide resolved
src/bindings/js/node/src/tensor.cpp Outdated Show resolved Hide resolved
@vishniakov-nikolai vishniakov-nikolai added the ExternalPR External contributor label Mar 26, 2024
@adismort14
Copy link
Contributor Author

adismort14 commented Mar 27, 2024

I have resolved both the comments in the latest commit. Kindly review it.

cc: @almilosz @vishniakov-nikolai

@almilosz
Copy link
Contributor

build_jenkins

@vishniakov-nikolai vishniakov-nikolai added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@almilosz almilosz added this pull request to the merge queue Apr 17, 2024
Merged via the queue into openvinotoolkit:master with commit ef2ca66 Apr 17, 2024
111 checks passed
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
…hape method (openvinotoolkit#23637)

This Fixes openvinotoolkit#23441 issue.

Details:

1. Modified get_shape() method to report error in case any argument is
passed.
2. Added Required Tests for the above in `tensor.test.js`.

---------

Co-authored-by: Vishniakov Nikolai <[email protected]>
Co-authored-by: Alicja Miloszewska <[email protected]>
@ilya-lavrenov ilya-lavrenov added this to the 2024.2 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: JS API OpenVino JS API Bindings ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Validate parameters of Tensor.getShape() method
4 participants