[PT FE] Support aten::concatenate #28518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxim Vafin <[email protected]>
rkazants
reviewed
Jan 19, 2025
| @@ -425,6 +425,7 @@ const std::unordered_map<std::string, CreatorFunction> get_supported_ops_ts() { | |||
| {"aten::col2im", op::translate_col2im}, | |||
| // aten::complex - Supported in limited set of patterns | |||
| {"aten::concat", op::translate_cat}, | |||
| {"aten::concatenate", op::translate_cat}, | |||
There was a problem hiding this comment.
how to reproduce such case in layer tests?
There was a problem hiding this comment.
this is rare case, when something went wrong with normalization in tracing, I think this is difficult to catch such behaviour in layer test and we can trust to torch aliasing system that torch.concatenate is alias for torch.cat
https://github.com/pytorch/pytorch/blob/dbed747aae223d53ca4e22fe45c24d1d9a8b4432/torch/csrc/jit/passes/normalize_ops.cpp#L131
rkazants
approved these changes
Jan 19, 2025
eaidova
approved these changes
Jan 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MirceaDan99
pushed a commit
to MirceaDan99/openvino
that referenced
this pull request
Jan 22, 2025
### Details: - *Support `aten::concatenate`* ### Tickets: - *CVS-160777* Signed-off-by: Maxim Vafin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
aten::concatenateTickets: