Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Common][Transformations] eliminated no needed split & concat #28827

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Common][Transformations] eliminated no needed split & concat #28827

wants to merge 4 commits into from
+305 −1

Conversation

zhaixuejun1993
Copy link
Contributor

@zhaixuejun1993 zhaixuejun1993 commented Feb 5, 2025 •
edited by ceciliapeng2011
Loading

Details:

  • Add StridedSlice::clone_with_new_inputs() func without stride behavior (i.e. the optional input of strides is without provided).
  • Eliminate split node & concat node for the following situation:
    Src
    image
    Target:
    image

Tickets:

@zhaixuejun1993 zhaixuejun1993 requested review from a team as code owners February 5, 2025 06:46
@zhaixuejun1993 zhaixuejun1993 requested review from itikhono and removed request for a team February 5, 2025 06:46
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: transformations OpenVINO Runtime library - Transformations labels Feb 5, 2025
@ceciliapeng2011
Copy link
Contributor

ceciliapeng2011 commented Feb 5, 2025 •
edited
Loading

Generally LGTM, will carefully check the preconditions of pattern.

@zhaixuejun1993
Fix error for dynamic shape
cf797d4 
Signed-off-by: Zhai, Xuejun <[email protected]>
@zhaixuejun1993 zhaixuejun1993 force-pushed the xuejun/opt-concat-split-concat-behavior branch from cb149e2 to cf797d4 Compare February 10, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz left review comments

@luweizhou2016 luweizhou2016 Awaiting requested review from luweizhou2016

@peterchen-intel peterchen-intel Awaiting requested review from peterchen-intel

@ceciliapeng2011 ceciliapeng2011 Awaiting requested review from ceciliapeng2011

@songbell songbell Awaiting requested review from songbell

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

@CuriousPanCake CuriousPanCake Awaiting requested review from CuriousPanCake

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaixuejun1993 @ceciliapeng2011 @praasz