Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE VPU] Fix condition in HW tiling #3111

Conversation

KorA6
Copy link
Contributor

@KorA6 KorA6 commented Nov 12, 2020

#-34250
#-33366

@KorA6 KorA6 requested a review from a team as a code owner November 12, 2020 18:40
@KorA6 KorA6 requested a review from a user November 12, 2020 18:40
@KorA6 KorA6 force-pushed the vpu/akorolev/fix_hwtiling_condition branch 2 times, most recently from b054527 to 2acee0d Compare November 13, 2020 05:43
@andrejsokolov andrejsokolov self-requested a review November 13, 2020 08:16
@rvyunov rvyunov self-requested a review November 13, 2020 08:17
if (inTileWidth > 507) {
return false;

if (inTileWidth > 507 && inTileHeight < 64 && type != HwOpType::POOL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of tiles with inTileHeight < 64 fail? Or some certain sizes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of them, but there are sizes less than 64 where hangs occur.
Perhaps the constant 64 should be larger.
This constant was obtained based on a sample from #31079.

@andrejsokolov andrejsokolov self-requested a review November 13, 2020 08:28
@KorA6 KorA6 force-pushed the vpu/akorolev/fix_hwtiling_condition branch 2 times, most recently from 139f3a2 to 2e4c08e Compare November 15, 2020 19:36
@KorA6 KorA6 force-pushed the vpu/akorolev/fix_hwtiling_condition branch from 2e4c08e to 2ad3ab8 Compare November 16, 2020 09:09
@Maxim-Doronin Maxim-Doronin merged commit 957a1f6 into openvinotoolkit:master Nov 17, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Nov 17, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants