[I420 color conversion] I420toRGB/I420toBGR reference implementation #8605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openvino-pushbot
added
category: TEMPLATE
ilya-lavrenov
approved these changes
Nov 15, 2021
Common plugin tests CPU compliance tests Serialization tests
jane-intel
reviewed
Nov 17, 2021
| namespace ngraph { | ||
| namespace op { | ||
| namespace v8 { | ||
| using ov::op::v8::I420toRGB; |
There was a problem hiding this comment.
Why do we add it to old structure?
It has no legacy place, so it seems we can only keep it in openvino/ folder
There was a problem hiding this comment.
@ilyachur Can you comment on this?
For NV12, you've requested to have such aliases in 'ngraph' namespace. See #7601 (comment)
Comment on lines
+97
to
+102
| if (!shape_uv[i420_op::H_DIM].is_dynamic()) { | ||
| shape_uv[i420_op::H_DIM] *= 2; | ||
| } | ||
| if (!shape_uv[i420_op::W_DIM].is_dynamic()) { | ||
| shape_uv[i420_op::W_DIM] *= 2; | ||
| } |
There was a problem hiding this comment.
Basically we can multiply dimensions without checking if it is dynamic. Please see
Suggested change
| if (!shape_uv[i420_op::H_DIM].is_dynamic()) { | |
| shape_uv[i420_op::H_DIM] *= 2; | |
| } | |
| if (!shape_uv[i420_op::W_DIM].is_dynamic()) { | |
| shape_uv[i420_op::W_DIM] *= 2; | |
| } | |
| shape_uv[i420_op::H_DIM] *= 2; | |
| shape_uv[i420_op::W_DIM] *= 2; |
Feel free to change it in the next PR -- as you stated in the description there will be a follow up PR.
jane-intel
approved these changes
Nov 17, 2021
ilyachur
approved these changes
Nov 18, 2021
| } | ||
| }; | ||
|
|
||
| TEST_F(ReferenceConvertColorI420LayerTest, CompareWithHardcodedRefs_r_u8_single_rgb) { |
There was a problem hiding this comment.
Looks like you can use parametrized tests
| bool visit_attributes(AttributeVisitor& visitor) override; | ||
|
|
||
| OPENVINO_SUPPRESS_DEPRECATED_START | ||
| bool evaluate(const HostTensorVector& outputs, const HostTensorVector& inputs) const override; |
There was a problem hiding this comment.
I think we can use new evaluate API
openvino-dev-samples
pushed a commit
to openvino-dev-samples/openvino
that referenced
this pull request
Nov 23, 2021
…penvinotoolkit#8605) * ngraph part * Template reference tests Common plugin tests CPU compliance tests Serialization tests * Clang format fixes * Remove reference implementation for f16, bf16, f64 types * Fix ninja build * Fix opset8_dump test * Fix opset8_dump test * Fix CentOS build * Removed Myriad preprocessing tests (to be added by separate PR)
openvino-dev-samples
pushed a commit
to openvino-dev-samples/openvino
that referenced
this pull request
Nov 24, 2021
…penvinotoolkit#8605) * ngraph part * Template reference tests Common plugin tests CPU compliance tests Serialization tests * Clang format fixes * Remove reference implementation for f16, bf16, f64 types * Fix ninja build * Fix opset8_dump test * Fix opset8_dump test * Fix CentOS build * Removed Myriad preprocessing tests (to be added by separate PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
TODO:
Tickets: