Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(toolchain): consolidate env vars and cleanup code #1124

Merged
merged 2 commits into from
Dec 24, 2024
Merged

refactor(toolchain): consolidate env vars and cleanup code #1124

merged 2 commits into from
Dec 24, 2024

Conversation

keroro520
Copy link
Contributor

Added constants for environment variable names to improve maintainability and prevent typos

jonathanpwang
jonathanpwang requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few small naming changes, but otherwise LGTM

jonathanpwang
jonathanpwang approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang
Copy link
Contributor

Benchmark workflow failing for unrelated reasons due to some fork permissions

@jonathanpwang jonathanpwang merged commit 2ef5f76 into openvm-org:main Dec 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroro520 @jonathanpwang