fix halo2 verifier guest code #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
approved these changes
Dec 26, 2024
| impl EcPointLoader<G1Affine> for OpenVmLoader { | ||
| type LoadedEcPoint = OpenVmEcPoint<G1Affine, EcPoint>; | ||
|
|
||
| fn ec_point_load_const(&self, value: &G1Affine) -> Self::LoadedEcPoint { | ||
| let point = EcPoint { | ||
| x: Fp::from_be_bytes(&value.x().to_bytes()), | ||
| y: Fp::from_be_bytes(&value.y().to_bytes()), | ||
| x: Fp::from_le_bytes(&value.x.to_bytes()), |
There was a problem hiding this comment.
just noting the halo2curves .to_bytes() actually does some computation, but with the way snark-verifier traits work, this seems unavoidable
jonathanpwang
added a commit
that referenced
this pull request
Dec 31, 2024
* make msm implementation with blackbox * feat: use msm_serial variant * feat: set up foundations * wip * implement accumulation decider * wip * wip * wip * wip * finish loader * finish decider * finish transcript(?) * add files * verifier code done * rename and clean * fix halo2 verifier guest code (#1137) * fix halo2 verifier guest code * clean * build * switch to workspace snark verifier * add tests for verifier * rename and add files * wip: make integration test * chore: protect EcPoint constructor * feat: add integration test * chore: remove unused * chore: lints --------- Co-authored-by: Zhang Zhuo <[email protected]> Co-authored-by: Jonathan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.