Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor metrics collection #1142

Merged
merged 12 commits into from
Dec 30, 2024
Merged

chore: refactor metrics collection #1142

merged 12 commits into from
Dec 30, 2024

Conversation

jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Dec 30, 2024

closes INT-2924

The collect_metrics flag in ExecutionSegment has been renamed to profiling for accuracy because when bench-metrics feature is enabled, at least some minimal set of metrics is always collected.

Turn off flamegraph profiling in benchmarks -- these will be made into a separate on-demand workflow in the near future.

This comment has been minimized.

Copy link
Contributor

@zlangley zlangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/vm/src/arch/segment.rs Outdated Show resolved Hide resolved
Copy link

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms max_segment_length instance alloc
ecrecover_program
2
15,230,037
(-290,016 [-50.0%])
290,016
(-10.0 [-0.4%])
2,354.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
fibonacci_program
2
51,505,102
(-1,500,137 [-50.0%])
1,500,137
(+11.0 [+0.2%])
5,474.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
regex_program
2
165,028,173
(-4,190,904 [-50.0%])
4,190,904
(-54.0 [-0.3%])
15,955.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
verify_fibair
2
(-61,258 [-0.4%])
14,529,472
(-201,874 [-50.8%])
195,420
(-74.0 [-4.8%])
1,477.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc

Commit: af3dadf

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 1e683b0 into main Dec 30, 2024
17 checks passed
@jonathanpwang jonathanpwang deleted the refactor/metrics branch December 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants