Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli build with profile #1143

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fix: cli build with profile #1143

merged 2 commits into from
Dec 30, 2024

Conversation

jonathanpwang
Copy link
Contributor

Closes #1141

Test also uncovered that the output target directory should be "debug" when profile is "dev".

This comment has been minimized.

Copy link

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms max_segment_length instance alloc
ecrecover_program
2
15,230,037
290,016
(-17.0 [-0.7%])
2,370.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
fibonacci_program
2
51,505,102
1,500,137
(+10.0 [+0.2%])
5,470.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
regex_program
2
165,028,173
4,190,904
(-106.0 [-0.7%])
15,724.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
verify_fibair
2
(+23,050 [+0.2%])
14,560,072
(+4 [+0.0%])
195,361
(+20.0 [+1.3%])
1,511.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc

Commit: d2d8128

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit fff23b3 into main Dec 30, 2024
12 checks passed
@jonathanpwang jonathanpwang deleted the fix/build-with-profile branch December 30, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--profile option to cargo openvm build doesn't do anything
1 participant