Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bench): verify_fibair use volatile memory #1145

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Dec 31, 2024

Cleanup benchmark so verify_fibair actually uses volatile memory (it should not have continuations enabled).
In the process:

  • rename get_vk to get_app_vk
  • add non-continuation prove and verify functions to AppProver
  • remove profiling flag from sdk provers: this should just be set in the VmConfig and we do not encourage rerunning execution twice

In this PR, the Fibonacci STARK number of rows is kept the same. In a future PR I may increase the number of rows in the to-be-verified STARK to make the benchmark bigger.

This comment has been minimized.

Copy link

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms max_segment_length instance alloc
ecrecover_program
2
15,230,037
290,016
(-23.0 [-1.0%])
2,342.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
fibonacci_program
2
51,505,102
1,500,137
(-48.0 [-0.9%])
5,450.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
regex_program
2
165,028,173
4,190,904
(+59.0 [+0.4%])
15,885.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
verify_fibair
2
(-6,386,998 [-44.0%])
8,121,174
(-15 [-0.0%])
195,357
(-39.0 [-2.6%])
1,444.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc

Commit: ebe83e9

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 8be41bd into main Dec 31, 2024
11 checks passed
@jonathanpwang jonathanpwang deleted the fix/verify_fibair branch December 31, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant