fix(bench): verify_fibair use volatile memory #1145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup benchmark so verify_fibair actually uses volatile memory (it should not have continuations enabled).
In the process:
get_vk
toget_app_vk
AppProver
profiling
flag from sdk provers: this should just be set in the VmConfig and we do not encourage rerunning execution twiceIn this PR, the Fibonacci STARK number of rows is kept the same. In a future PR I may increase the number of rows in the to-be-verified STARK to make the benchmark bigger.