chore: pairing_check_hint for #[cfg(not(target_os = "zkvm"))]
#1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: 073315d |
ytham
changed the title
pairing_check_hint for #[cfg(not(target_os = "zkvm"))]pairing_check_hint for #[cfg(not(target_os = "zkvm"))]
jonathanpwang
requested changes
Jan 7, 2025
| @@ -275,7 +281,68 @@ impl PairingCheck for Bls12_381 { | |||
| ) -> (Self::Fp12, Self::Fp12) { | |||
| #[cfg(not(target_os = "zkvm"))] | |||
| { | |||
| todo!() | |||
| let f = Self::multi_miller_loop(P, Q); | |||
There was a problem hiding this comment.
I would prefer for code maintenance if you just converted to halo2 curves type and called the associated method there. this duplicate code is not good for upkeep
There was a problem hiding this comment.
hm, unfortunately halo2curves computes the Gt value for final exponentiation directly and doesn't have a separate residue witness and cubic nonresidue power/scaling factor calculation, so it doesn't seem like there's a good way to calculate these values directly via halo2curves
|
Closing in favor of #1253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pairing_check_hintfor#[cfg(not(target_os = "zkvm"))]for BN254 and BLS12-381