Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: constrain address spaces in native extension #1305

Merged
merged 11 commits into from
Jan 27, 2025
Merged

feat: constrain address spaces in native extension #1305

merged 11 commits into from
Jan 27, 2025

Conversation

yi-sun
Copy link
Collaborator

@yi-sun yi-sun commented Jan 27, 2025 •
edited
Loading

Closes INT-3148

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@yi-sun yi-sun requested a review from jonathanpwang January 27, 2025 02:37
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@yi-sun yi-sun force-pushed the feat/native-as-constraints branch from 6653903 to e55d0ee Compare January 27, 2025 03:19
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
jonathanpwang
jonathanpwang approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-6 [-0.3%]) 2,197 513,827 (-666027 [-3.4%]) 18,710,764 - - -
fibonacci_program 5,342 1,500,095 51,485,080 - - -
regex_program (+94 [+0.6%]) 15,381 1,914,103 165,455,373 - - -
fib_e2e 36,355 1,515,083 410,691,902 48,684 12,110,029 436,508,061
ecrecover_program (+24 [+0.9%]) 2,592 284,567 15,055,723 - - -

Commit: a257a64

Benchmark Workflow

@yi-sun yi-sun merged commit 13036e7 into main Jan 27, 2025
18 checks passed
@yi-sun yi-sun deleted the feat/native-as-constraints branch January 27, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
run-benchmark-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yi-sun @jonathanpwang