Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove incorrect nop transpilation for intrinsics #1306

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

yi-sun
Copy link
Collaborator

@yi-sun yi-sun commented Jan 27, 2025

Closes INT-3149

This comment has been minimized.

@yi-sun yi-sun force-pushed the feat/native-as-constraints branch from 6653903 to e55d0ee Compare January 27, 2025 03:19
@yi-sun yi-sun force-pushed the feat/intrinsic-noop-transpile branch from e225449 to ef76a33 Compare January 27, 2025 03:20

This comment has been minimized.

@yi-sun yi-sun force-pushed the feat/intrinsic-noop-transpile branch 2 times, most recently from f79d937 to 746b39e Compare January 27, 2025 04:03
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also handle SETUP_ISEQ_MOD.
I checked the ISA again and to the best of my knowledge that is the only other case where address space 1 is written to.

This comment has been minimized.

Base automatically changed from feat/native-as-constraints to main January 27, 2025 05:12
@yi-sun yi-sun force-pushed the feat/intrinsic-noop-transpile branch from 746b39e to 30926c9 Compare January 27, 2025 05:13

This comment has been minimized.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-13 [-0.6%]) 2,174 513,915 18,711,556 - - -
fibonacci_program (+29 [+0.5%]) 5,318 1,500,095 51,485,080 - - -
regex_program (+110 [+0.7%]) 15,344 1,914,103 165,455,373 - - -
fib_e2e 36,343 1,515,083 410,691,902 49,141 12,110,252 436,510,068
ecrecover_program 2,588 284,567 15,055,723 - - -

Commit: f3795ad

Benchmark Workflow

@yi-sun yi-sun merged commit dc9b8ae into main Jan 27, 2025
17 checks passed
@yi-sun yi-sun deleted the feat/intrinsic-noop-transpile branch January 27, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants