-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[perf] VerifyBatch direct hint #1328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
221cbd2
to
532cd19
Compare
This comment has been minimized.
This comment has been minimized.
532cd19
to
cfb6eb2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Please fill out Perf PR Template. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except update spec and many sibling_id
were not renamed to proof_id
This comment has been minimized.
This comment has been minimized.
Commit: 8c0088c |
jonathanpwang
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerifyBatch
chip hints merkle proofs directly instead reads from memory. This saves some cells for hinting and some columns of memory operations. This is valid because all merkle proofs are just read once.Comparison on c7a.48xlarge: reth bench
Comparison on c8g.48xlarge: reth bench
Ecrecover leaf flamegraph before
Ecrecover leaf flamegraph after
Metric: used cells in Ecrecover leaf flamegraph
Before:
158,652,038
This PR:
142,929,350
Perf diff: -10%.
closes INT-3186