Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testing function for partitioned and cached traces #486

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

OsamaAlkhodairy
Copy link
Contributor

@OsamaAlkhodairy OsamaAlkhodairy commented Oct 1, 2024

Added test functions to StarkEngine that automatically do keygen, proving, and verifying when partitions of the trace are cached, utilizing #481. Edited the tests for IndexedOutputPageAir to showcase usage. Much cleaner now!

Relevant to INT-2203

@OsamaAlkhodairy OsamaAlkhodairy force-pushed the feat/test-cached-traces branch from 151d9b2 to 902a530 Compare October 1, 2024 06:00
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Maybe this can save @nyunyunyunyu some work - we were discussing further automating some parts of the keygen to remove matrix pointers.
Will let @nyunyunyunyu merge in case there's any conflicts with what he's currently doing.

@nyunyunyunyu nyunyunyunyu merged commit d1c099f into main Oct 1, 2024
14 checks passed
@nyunyunyunyu nyunyunyunyu deleted the feat/test-cached-traces branch October 1, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants