Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Runtime for short weierstrass curve operations over Fp #566

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

luffykai
Copy link
Contributor

fix INT-2326

Copy link

linear bot commented Oct 15, 2024

INT-2326 Runtime for short weierstrass curve operations over Fp

  • sw_add_ne
  • sw_double

must support different NUM_LIMBS, LIMB_BITS=8, but the batch read size may differ.

@luffykai luffykai force-pushed the lunkai/sw branch 2 times, most recently from bfa1dac to dcca1b1 Compare October 17, 2024 04:42
@luffykai luffykai marked this pull request as ready for review October 17, 2024 04:43
@luffykai luffykai requested a review from yi-sun October 17, 2024 22:53
Copy link
Collaborator

@yi-sun yi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small nits.

vm/src/intrinsics/ecc_v2/sw/README.md Outdated Show resolved Hide resolved
vm/src/intrinsics/ecc_v2/sw/double.rs Outdated Show resolved Hide resolved
@luffykai luffykai merged commit 5a588b9 into main Oct 17, 2024
9 checks passed
@luffykai luffykai deleted the lunkai/sw branch October 17, 2024 23:50
luffykai added a commit that referenced this pull request Dec 13, 2024
* skeleton

* wip

* u32

* sw add ne

* works

* fix and rename

* undo

* address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants