Merge pull request #2144 from sicpa-dlab/feature/allow-non-sov-public…

…ation feat: allow marking non-SOV DIDs as public
openwallet-foundation · Mar 1, 2023 · 9300ac9 · 9300ac9
2 parents c450a92 + 172b6f5
commit 9300ac9
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 33 deletions.
diff --git a/aries_cloudagent/wallet/askar.py b/aries_cloudagent/wallet/askar.py
@@ -396,9 +396,6 @@ async def set_public_did(self, did: Union[str, DIDInfo]) -> DIDInfo:
             info = did
             item = None
 
-        if info.method != SOV:
-            raise WalletError("Setting public DID is only allowed for did:sov DIDs")
-
         public = await self.get_public_did()
         if not public or public.did != info.did:
             storage = AskarStorage(self._session)

diff --git a/aries_cloudagent/wallet/in_memory.py b/aries_cloudagent/wallet/in_memory.py
@@ -17,7 +17,7 @@
 )
 from .did_info import KeyInfo, DIDInfo
 from .did_posture import DIDPosture
-from .did_method import SOV, DIDMethod, DIDMethods
+from .did_method import DIDMethod, DIDMethods
 from .error import WalletError, WalletDuplicateError, WalletNotFoundError
 from .key_type import KeyType
 from .util import b58_to_bytes, bytes_to_b58, random_seed
@@ -383,9 +383,6 @@ async def set_public_did(self, did: Union[str, DIDInfo]) -> DIDInfo:
             info = did
             did = info.did
 
-        if info.method != SOV:
-            raise WalletError("Setting public DID is only allowed for did:sov DIDs")
-
         public = await self.get_public_did()
         if public and public.did == did:
             info = public

diff --git a/aries_cloudagent/wallet/indy.py b/aries_cloudagent/wallet/indy.py
@@ -687,9 +687,6 @@ async def set_public_did(self, did: Union[str, DIDInfo]) -> DIDInfo:
         else:
             info = did
 
-        if info.method != SOV:
-            raise WalletError("Setting public DID is only allowed for did:sov DIDs")
-
         public = await self.get_public_did()
         if not public or public.did != info.did:
             if not info.metadata.get("posted"):

diff --git a/aries_cloudagent/wallet/tests/test_in_memory_wallet.py b/aries_cloudagent/wallet/tests/test_in_memory_wallet.py
@@ -346,17 +346,6 @@ async def test_create_public_did(self, wallet: InMemoryWallet):
             info_replace.did,
         }
 
-    @pytest.mark.asyncio
-    async def test_create_public_did_x_not_sov(self, wallet: InMemoryWallet):
-        with pytest.raises(WalletError) as context:
-            await wallet.create_public_did(
-                KEY,
-                ED25519,
-            )
-        assert "Setting public DID is only allowed for did:sov DIDs" in str(
-            context.value
-        )
-
     @pytest.mark.asyncio
     async def test_create_public_did_x_unsupported_key_type_method(
         self, wallet: InMemoryWallet
@@ -400,18 +389,6 @@ async def test_set_public_did(self, wallet: InMemoryWallet):
         assert info_final.did == info_new.did
         assert info_final.metadata.get("posted")
 
-    @pytest.mark.asyncio
-    async def test_set_public_did_x_not_sov(self, wallet: InMemoryWallet):
-        info = await wallet.create_local_did(
-            KEY,
-            ED25519,
-        )
-        with pytest.raises(WalletError) as context:
-            await wallet.set_public_did(info.did)
-        assert "Setting public DID is only allowed for did:sov DIDs" in str(
-            context.value
-        )
-
     @pytest.mark.asyncio
     async def test_sign_verify(self, wallet: InMemoryWallet):
         info = await wallet.create_local_did(