Merge pull request #258 from andrewwhitehead/fix/no-cookies

Disable cookies on outbound requests
openwallet-foundation · Nov 8, 2019 · e34b277 · e34b277
2 parents ca0e463 + 250aace
commit e34b277
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/aries_cloudagent/admin/server.py b/aries_cloudagent/admin/server.py
@@ -5,7 +5,7 @@
 from typing import Coroutine, Sequence, Set
 import uuid
 
-from aiohttp import web, ClientSession
+from aiohttp import web, ClientSession, DummyCookieJar
 from aiohttp_apispec import docs, response_schema, setup_aiohttp_apispec
 import aiohttp_cors
 
@@ -382,6 +382,7 @@ async def _process_webhooks(self):
         collector: Collector = await self.context.inject(Collector, required=False)
         if collector:
             session_args["trace_configs"] = [StatsTracer(collector, "webhook-http:")]
+        session_args["cookie_jar"] = DummyCookieJar()
         self.webhook_session = ClientSession(**session_args)
         self.webhook_processor = TaskProcessor(max_pending=20)
         async for topic, payload in self.webhook_queue:

diff --git a/aries_cloudagent/transport/outbound/http.py b/aries_cloudagent/transport/outbound/http.py
@@ -2,7 +2,7 @@
 
 import logging
 
-from aiohttp import ClientSession
+from aiohttp import ClientSession, DummyCookieJar
 
 from ...messaging.outbound_message import OutboundMessage
 from ..stats import StatsTracer
@@ -27,6 +27,7 @@ async def start(self):
             session_args["trace_configs"] = [
                 StatsTracer(self.collector, "outbound-http:")
             ]
+        session_args["cookie_jar"] = DummyCookieJar()
         self.client_session = ClientSession(**session_args)
         return self
 

diff --git a/aries_cloudagent/transport/outbound/ws.py b/aries_cloudagent/transport/outbound/ws.py
@@ -2,7 +2,7 @@
 
 import logging
 
-from aiohttp import ClientSession
+from aiohttp import ClientSession, DummyCookieJar
 
 from ...messaging.outbound_message import OutboundMessage
 
@@ -21,7 +21,7 @@ def __init__(self) -> None:
 
     async def start(self):
         """Start the outbound transport."""
-        self.client_session = ClientSession()
+        self.client_session = ClientSession(cookie_jar=DummyCookieJar())
         return self
 
     async def stop(self):