Fixed potential deadlocks by opening sessions only on demand (Wallet endpoints) #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acuderman
force-pushed
the
feat-IDENT-3671-wallet-seesions-askar
branch
from
36ea6ea to
cc69732
Compare
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
- Coverage 95.81% 95.81% -0.01%
==========================================
Files 489 489
Lines 30018 30027 +9
==========================================
+ Hits 28762 28770 +8
- Misses 1256 1257 +1 |
acuderman
force-pushed
the
feat-IDENT-3671-wallet-seesions-askar
branch
from
cc69732 to
86bb36b
Compare
…wallet Signed-off-by: Andraž Cuderman <[email protected]>
… use seperate sessions for wallet calls Signed-off-by: Andraž Cuderman <[email protected]>
…on wallet_rotate_did_keypair Signed-off-by: Andraž Cuderman <[email protected]>
…sort out Signed-off-by: Andraž Cuderman <[email protected]>
…needed Signed-off-by: Andraž Cuderman <[email protected]>
acuderman
force-pushed
the
feat-IDENT-3671-wallet-seesions-askar
branch
3 times, most recently
from
699f9b3 to
3c8e2f9
Compare
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
acuderman
force-pushed
the
feat-IDENT-3671-wallet-seesions-askar
branch
from
3c8e2f9 to
1d05f73
Compare
ianco
approved these changes
Nov 2, 2021
|
@acuderman can you sync up with the latest updates in the |
|
@ianco thanks for the review. Branch is synced with main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed potential deadlocks for Wallet endpoints
Additional info in this issue: #1417