-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve definitions.py fix to fix backwards compatibility break in plugins #2255
Resolve definitions.py fix to fix backwards compatibility break in plugins #2255
Conversation
Include searching by the module base package when resolving plugin definitions location. Signed-off-by: Jason Sherman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. I'll follow up on testing with the example plugin I referred to #2224 in response to your comments on the same issue!
Signed-off-by: Jason Sherman <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
I am hoping to test myself first -- not that I don't trust the fix lol just want to verify the fix and my understanding before calling it good. I can run it through a couple of plugins in addition to the minimal example provided in #2224 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working for at least one of our plugins that was previously broken. Thanks!
@dbluhm — should this trigger a new release — presumably 0.8.2? |
Yes |
Include searching by the module base package when resolving plugin definitions location.
Fixes #2224
This still depends on the module package names and file system paths matching up, which is not guaranteed. But without adding additional configuration in the plugin registry, I think this is all we can do.