Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update lock file #3296

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented Oct 15, 2024

Includes many new patch releases.
Some noteworthy ones appear to be:

  • aiohttp (3.10.5 -> 3.10.10)
  • pydantic (2.8.2 -> 2.9.2)
  • yarl (1.9.4 -> 1.15.2)

@ff137
Copy link
Contributor Author

ff137 commented Oct 15, 2024

Looks like the dependency upgrades has unearthed a buggy unit test:

FAILED acapy_agent/protocols/issue_credential/v2_0/tests/test_routes.py::TestV20CredRoutes::test_credential_exchange_send_bound_offer_linked_data_error - TypeError: argument of type 'LinkedDataProofException' is not iterable

Taking a look

@ff137
Copy link
Contributor Author

ff137 commented Oct 15, 2024

aiohttp probably had a minor change to their exception handling.
We were passing a LinkedDataProofException object as the "reason" for the HTTPBadRequest. Which now results in a TypeError. This is fixed by converting the exception to a string

Copy link

@jamshale jamshale merged commit 469d624 into openwallet-foundation:main Oct 16, 2024
10 checks passed
ff137 added a commit to ff137/acapy that referenced this pull request Oct 22, 2024
* ⬆️ Update lock file

Signed-off-by: ff137 <[email protected]>

* ✅ ensure HTTPBadRequest reason is a string

Signed-off-by: ff137 <[email protected]>

---------

Signed-off-by: ff137 <[email protected]>
Co-authored-by: Stephen Curran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants