🎨 Refactor string concatenation in model descriptions #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
|
Not sure why this got caught in the unit tests but not ruff linting check, but looks like one line is too long.
|
Signed-off-by: ff137 <[email protected]>
|
@jamshale Thanks! Forgot to check |
|
jamshale
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor artsy cleanup --
I noticed that using the backslash for line continuation includes all the whitespace of the code indentation in the final string. So, the openapi docs would generate a description as:
So, quick fix: replace \ for line continuation with string concatenation
edit: also fixes mediation typo, while I'm at it