-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrade dependencies #3455
⬆️ Upgrade dependencies #3455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to move forward on this but we need to get a patch release done before these changes go in. Will block until that is complete.
Will also have to debug why agent in interop test doesn't start up |
We're seeing that happening in the Agent Test Harness tests as well - intermittent non-starting of the agent. Might be the issue. |
@swcurran I included unpinning of the remaining dependencies that were set to 1 specific version, and some last improvements. Which will hopefully help improve on that scorecard. Tried upgrading to next marshmallow release, but 1 pytest broke, and didn't have time to dig into it now. So leaving marshmallow upgrade for later edit: managed to figure out the Marshmallow change -- just a |
https://pypi.org/project/aiohttp-apispec-acapy/3.0.3/ Is now available with the unpinned dependencies if you want to include it in this PR. |
async-timeout has been pulled into asyncio since python 3.11 Signed-off-by: ff137 <[email protected]>
Includes major upgrades without breaking changes Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Remove deprecated field (order is now preserved by default) Handle new TypeError Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Fixes: `ChangedInMarshmallow4Warning: Returning `False` from a validator is deprecated. Raise a `ValidationError` instead.` Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Awesome, thank you! Included One step closer to running with 3.13 👀 edit: just got saw all PR tests pass in python3.13 🚀 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and tests are all passing so should be safe 👍
@@ -303,6 +303,10 @@ async def asyncSetUp(self): | |||
headers={"x-api-key": "secret-key"}, | |||
) | |||
|
|||
async def asyncTearDown(self): | |||
# Ensure the event loop is closed | |||
await self.profile.close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* ➖ Remove deprecated package async-timeout has been pulled into asyncio since python 3.11 Signed-off-by: ff137 <[email protected]> * ⬆️ Upgrade dependencies Includes major upgrades without breaking changes Signed-off-by: ff137 <[email protected]> * 📌 Unpin dependency versions Signed-off-by: ff137 <[email protected]> * ⬆️ Upgrade pre-commit Signed-off-by: ff137 <[email protected]> * 🎨 Fix deprecation warning - module moved Signed-off-by: ff137 <[email protected]> * ⬆️ Upgrade marshmallow Remove deprecated field (order is now preserved by default) Handle new TypeError Signed-off-by: ff137 <[email protected]> * ⬆️ Update lock file Signed-off-by: ff137 <[email protected]> * 🎨 Resolve Marshmallow deprecation warning Fixes: `ChangedInMarshmallow4Warning: Returning `False` from a validator is deprecated. Raise a `ValidationError` instead.` Signed-off-by: ff137 <[email protected]> * 🎨 Fix pytest-asyncio warning: unclosed event loop Signed-off-by: ff137 <[email protected]> * ⬆️ Upgrade aiohttp-apispec-acapy Signed-off-by: ff137 <[email protected]> * ⬆️ Upgrade pydevd-pycharm Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]>
Includes major upgrades, where I've eyeballed changelogs to confirm they don't include relevant breaking changes. We'll let the tests be the judge.
➖ Removes
async-timeout
, as it's been pulled intoasyncio
⬆️ Upgrades:
🎨 Resolves deprecation warnings
The only packages that remain outdated:
- apispec (6.6.1 vs 6.8.1)- webargs (8.4.0 vs 8.6.0)^ these are held back by
aiohttp-apispec-acapy
@jamshale I've upgrade the fork to be more permissive for these dependencies, so they can be upgraded: https://github.com/ff137/aiohttp-apispec
Edit: thanks Jamie! Upgrade included
^ held back by did-webvh, which needs more relaxed restriction on askar: decentralized-identity/didwebvh-py#18
^ This is the only one that includes relevant breaking changes. Doesn't seem significant, but it requires some focus
(see https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/CHANGELOG -- 3.0.0 release:
patch_stdout
now requires anApplication
as input.)