Add multiple kid per key feature, kid removal and get by kid routes #3472
+138
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
|
jamshale
reviewed
Jan 27, 2025
| @@ -131,14 +135,58 @@ async def assign_kid_to_key(self, verkey: str, kid: str) -> KeyInfo: | |||
| if not key_entry: | |||
| raise WalletNotFoundError(f"No key entry found for verkey {verkey}") | |||
|
|
|||
| try: | |||
| existing_kid = key_entry.tags.get("kid") | |||
There was a problem hiding this comment.
key_entry.tags.get("kid", [])
jamshale
reviewed
Jan 27, 2025
| raise WalletError(f"Unknown key type {key.algorithm.value}") | ||
| try: | ||
| existing_kid.remove(kid) | ||
| except Exception: |
There was a problem hiding this comment.
Should catch the correct type of exception for removing entry that doesn't exist. Can't remember of the top of my head.
In general try to only catch the base Exception class when nessecary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.