-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Implement anoncreds credential format #901
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Question for @swcurran @jamshale - how should we handle tests tagged with Some tests (that create schemas, issue credentials, etc) interpret the Some tests (like those in I'm updating the anoncreds-dependant tests to check that the agent is running with the correct wallet type, and failing with a But the question is - should we setup a separate set of test suites that use Or alternately we can force-restart each agent to run Right now the |
I think I intended for this to be a separate suite to make things easy. But, the tests should in theory be an acapy issuer to credo holder, and either being a verifier in the suite. We don't know if these actually pass at this point, though. |
Note that some tests are failing when running under an |
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
This PR add support for using the
anoncreds
credential format, and adds a test suite for aca-py running--wallet-type askar-anoncreds
.See issue #872
I have updated the tags so that all anoncreds-specific tests are tagged with
@Anoncreds
, and I've added a filter to the existing test runs (using--wallet-type askar
) to exclude these tests.I've updated the rest of the tests so that anything using an
indy
credential exchange is tagged@Indy
(or@CredFormat_Indy
and these are excluded from the anoncreds test run.This PR includes a reference to the updated connections plug-in in @jamshale 's branch, so this PR should not be merged until after this connections plug-in is merged (and the relevant files in this PR updated) so that we're not chasing down spurious test errors.
The anoncreds test run looks as follows:
There are still some outstanding issues (can be included in this PR before merging or fixed later):
askar-anoncreds
agent should support. Right now all Indy tests are being excluded.