Improve the accuracy of the degree unit. #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the factor of a the base radian unit is hard coded with accuracy to 9 signigicant digits. This changes to computing the factor from the variable `$PI` defined in `Units.pm` to be `4 atan2(1, 1)` which gives as good of accuracy as can be obtained (seems to be 15 significant digits of accuracy). I have seen propogation of rounding error occur too frequently with the current estimate. That of course can still happen, but this makes it better at least.
Alex-Jordan
approved these changes
Mar 2, 2025
pstaabp
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the factor of a the base radian unit is hard coded with accuracy to 9 signigicant digits. This changes to computing the factor from the variable
$PIdefined inUnits.pmto be4 atan2(1, 1)which gives as good of accuracy as can be obtained (seems to be 15 significant digits of accuracy).I have seen propogation of rounding error occur too frequently with the current estimate. That of course can still happen, but this makes it better at least.