-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaffold section numbering #579
Conversation
I'm not sure what I was thinking, but obviously adding to and subtracting from |
Do mean to adjust |
@dpvc That's where I landed when I went back to look at alternatives last night. I'm still looking at if that could cause unforeseen consequences depending on what is inside each section. Probably not, at least not that I can think of so far. The other thing I was consider is using the changepage package. |
With the 2.16 release candidate announced, is it still OK to direct this PR (and others) to the 2.16 branch? I'm sorry I haven't been able to attend the release team meetings. This coming week is my last week of class for the term, and I'll be up for most meetings after that. |
It is still okay to target small changes to the 2.16 branch. Bigger changes will probably be deferred. It doesn't hurt to target the branch though. We can always change it and say it needs to wait. |
I made it add/subtract to/from |
I added a commit here that is PreTeXt-specific. We will be retiring the "stage" element in favor of the "task" element for subdividing an exercise, and that might as well happen now on the WeBWorK side. |
This is ready for a review now alongside openwebwork/webwork2#1383. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay. I don't think that nesting accordions is that great of an idea in general. I also am not fond of the numbering system implemented (a.i.A, a.i.B, a.ii.A, etc).
Since the defaults are maintained without the new option, I approve.
This is the default enumeration scheme with LaTeX. Well, it's really (a), then i., then A. Starting at depth 2 since the problem number itself is depth 1. |
I agree and I have no plans personally to use this, but I need to make it work in a nested manner with enumeration for PreTeXt's purposes. There, an |
I see. In the context of a problem I prefer to use upper case alphabetic characters for parts, and never nest past the first level. I try to avoid roman numerals because students can't count past three in that system (if that). In any case, I think this pull request (and the paired webwork2 PR) is good. It would be good if someone else took a look though. |
I changed this to be less excessive. It now only supports numbers up to 99 at each depth (up to cu, xcix, CU). And unlike before, if you exceed the maximum that it supports, you still get good numbers but they are left as arabic. |
This pull request (and the accompanying openwebwork/webwork2#1383) is holding up some PreTeXt development. Assuming @drgrice1 and I approve it, could I ask for one more review to meet our three-approval standard? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This adds an option for each
Scaffold()
to have numbering. There is a companion PR for styling at openwebwork/webwork2#1383.In addition to the
numbered => 1
option, I tweaked styling for nested scaffolds. In LaTeX, they now indent 1em for each level of depth. And in HTML, they no longer contract in width from the right, only from the left.Here is a simple test file demonstrating sections with depth, and the various numbering and title combinations.