Update the resource slug for the webwork2.pot file in tx/config. #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that one downside of not changing this is that if someone does use the Transifex command line client is used to push resources (tx push -s) then it will create a new resource with the same name webwork2.pot and the old slug webwork2pot to Transifex. Creating a duplicate of the existing resource. |
The slug was created initially in Transifex as webwork2pot, and must be before GitHub integrations are set up. Once GitHub integrations are set up linking Transifex to the repository the slug is automatically changed in Transifex to the full path of the resource in the GitHub repository (with hyphens instead of forward slashes) and the branch name. So this needs to be changed in the tx/config file. I meant to do this in openwebwork#1632 because I had read that this would happen, but forgot. This is not particularly important as this file is only used for the Transifex command line client, and most developers (even myself) will rarely use that. It is useful to have though.
drgrice1
force-pushed
the
update-transifex-resource-slug
branch
from
d9f9d09 to
8957c27
Compare
|
Any reason not to just merge this? |
|
No reason not to. It is a minor change, and won't affect anyone but developers working with the tx cli. Most developers won't even be doing that. If anyone is interested, I can tell you how to use the tx cli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slug was created initially in Transifex as webwork2pot, and must be before GitHub integrations are set up. Once GitHub integrations are set up linking Transifex to the repository the slug is automatically changed in Transifex to the full path of the resource in the GitHub repository (with hyphens instead of forward slashes) and the branch name. So this needs to be changed in the tx/config file.
I meant to do this in #1632 because I had read that this would happen, but forgot.
This is not particularly important as this file is only used for the Transifex command line client, and most developers (even myself) will rarely use that. It is useful to have though.