option to 'clean' a course just after unarchiving it #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
reviewed
Jan 4, 2024
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jan 9, 2024
drgrice1
requested changes
Jan 9, 2024
templates/ContentGenerator/CourseAdmin/unarchive_course_confirm.html.ep
Outdated
Show resolved
Hide resolved
templates/ContentGenerator/CourseAdmin/unarchive_course_form.html.ep
Outdated
Show resolved
Hide resolved
templates/ContentGenerator/CourseAdmin/unarchive_course_form.html.ep
Outdated
Show resolved
Hide resolved
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jan 9, 2024
Alex-Jordan
added a commit
to Alex-Jordan/webwork2
that referenced
this pull request
Jan 10, 2024
Implement suggestions in my review of openwebwork#2291.
Alex-Jordan
pushed a commit
to Alex-Jordan/webwork2
that referenced
this pull request
Jan 10, 2024
Alex-Jordan
force-pushed
the
clean-unarchived
branch
from
9fa8b7a to
3b63977
Compare
drgrice1
approved these changes
Jan 10, 2024
drgrice1
reviewed
Jan 10, 2024
|
I made the two edits that you caught, thanks. |
Alex-Jordan
pushed a commit
to Alex-Jordan/webwork2
that referenced
this pull request
Jan 20, 2024
Alex-Jordan
force-pushed
the
clean-unarchived
branch
from
72c0a93 to
3282c74
Compare
Alex-Jordan
force-pushed
the
clean-unarchived
branch
from
3282c74 to
910e125
Compare
|
This looks good. I was getting a number of errors related to existing directories--some due to failed unarchiving. This is unrelated to this PR, but I wonder about being able to handle some of this better--either removing a new course directory if it fails to be made or the ability to overwrite an existing directory. |
pstaabp
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a checkbox to the unarchive course page, and if checked, then when the course is unarchived it will be "cleaned". Cleaning means:
Another small thing is that this removes the checkbox for giving a new course name. If you've entered something into the field for the new course name, that is enough, and the checkbox is redundant.