Add schema generation support for plain GeometryFields #259
Conversation
|
Fairly simple change, but looking for some feedback on the best way to write a test for this. |
| serializer = inspector.get_serializer(path, method) | ||
| content = inspector.map_serializer(serializer) | ||
|
|
||
| print(content) |
There was a problem hiding this comment.
can we compare content against the expected value?
There was a problem hiding this comment.
Absolutely haha. That's my bad, I had uncommitted changes before pushign
AndrewGuenther
force-pushed
the
support-schema-generation-for-geometry-fields
branch
from
7735af3 to
a396ca8
Compare
|
I believe I've resolved all the issues. Fwiw, the |
…#257 The intial implementation of schema generation only supported serializers which subclassed GeoFeatureModel*Serializer. This meant that models which have standalone GeometryFields would not properly generate a schema. This change adds support for that use case. Closes openwisp#257
AndrewGuenther
force-pushed
the
support-schema-generation-for-geometry-fields
branch
from
a396ca8 to
99ee740
Compare
|
I'd say it's a pure bug fix. The documentation says that schema generation is supported, but it was only working for a specific case. This change ensures that schema generation works for all field types. |
|
The test failures seem related to some DB setup, not anything to do with this change. |
There was a problem hiding this comment.
LGTM
@dhaval-mehta @auvipy any idea why this failure? "database connection isn't set to UTC". Looks a psycopg issue to me, most probably is happening in master as well.
Yes. psycopg/psycopg2#1293 |
The intial implementation of schema generation only supported
serializers which subclassed GeoFeatureModel*Serializer. This meant that
models which have standalone GeometryFields would not properly generate
a schema. This change adds support for that use case.
Fixes #257