Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Remove support for restoring FirmwareBuild objects #170

Closed
nemesifier opened this issue Jan 18, 2022 · 0 comments · Fixed by #173
Closed

[change] Remove support for restoring FirmwareBuild objects #170

nemesifier opened this issue Jan 18, 2022 · 0 comments · Fixed by #173
Labels
enhancement New feature or request
Milestone
Release 1.0.0

Comments

@nemesifier
Copy link
Member

When firmware builds are deleted, related images are deleted too (let's double check this), therefore restoring FirmwareBuild objects does not make sense because firmware images will be missing.
@nemesifier nemesifier added the enhancement New feature or request label Jan 18, 2022
@nemesifier nemesifier mentioned this issue Jan 20, 2022
Open
@AbhigyaShridhar AbhigyaShridhar mentioned this issue Jan 21, 2022
Merged
AbhigyaShridhar added a commit to AbhigyaShridhar/openwisp-firmware-upgrader that referenced this issue Jan 25, 2022
@AbhigyaShridhar
[firmware-upgrader] Removed Recovery option for Builds openwisp#170
87ec2ba 
Replaced Version Admin with ModelAdmin as a superclass in admin.py/BuildAdmin,
Also removed the reversion_register function which was meant to register the model
associated with BuildAdmin (Firmware Build), for recovery option.

Fixes openwisp#170
@pandafy pandafy added this to the Release 0.2.0 milestone Jan 26, 2022
AbhigyaShridhar added a commit to AbhigyaShridhar/openwisp-firmware-upgrader that referenced this issue Feb 13, 2022
@AbhigyaShridhar
[admin] Removing reversion support for FirmwareBuild openwisp#170
2ee5cb0 
In admin.py, replaced BaseVersionAdmin from BaseAdmin,
as a superclass for 'BuildAdmin', as it is no longer
desired to add a recovery option for firmware builds and images

Fixes openwisp#170
AbhigyaShridhar added a commit to AbhigyaShridhar/openwisp-firmware-upgrader that referenced this issue Feb 15, 2022
@AbhigyaShridhar
[admin] Removed reversion support from Firmware Builds openwisp#170
6c4b1b8 
Replaced BaseVersionAdmin from BaseAdmin as a super class
in BuildAdmin and removed reversion support from BuildAdmin,
thus no longer allowing recovery of deleted Firmware Builds.

Also removed the overriding of the 'reversion_register' method
in CategoryAdmin to avoid failure of tests.

Fixes openwisp#170
nemesifier pushed a commit that referenced this issue Feb 23, 2022
@AbhigyaShridhar
[change] Removed reversion history support from Build objects #170
999b17e 
Closes #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
OpenWISP Priorities for next releases
Archived in project
Milestone
Release 1.0.0
2 participants
@nemesifier @pandafy