-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[change] Download batch CSV URL is inconsistent and not showing up in API docs #373
Comments
Hi, I want to start contributing and work on this issue. |
Hi @dishantsethi, Thanks for your interest in contributing!
Read also the rest and it will save everyone's time. |
URL generated with radius:serve_private_file was not consistent with the rest of the API URLs Changed Download batch CSV API endpoint from radiusbatch/csv/<uuid>/filename.csv to radius/organization/<slug:slug>/batch/<uuid:pk>/csv/filename.csv and added the same in API documentation as well. Fixes issue openwisp#373
URL generated with radius:serve_private_file was not consistent with the rest of the API URLs Changed Download batch CSV API endpoint from radiusbatch/csv/<uuid>/filename.csv to radius/organization/<slug:slug>/batch/<uuid:pk>/csv/filename.csv and added the same in API documentation as well. Fixes issue openwisp#373
* URL generated with radius:serve_private_file was not consistent with the rest of the API URLs. * Changed Download batch CSV API endpoint from radiusbatch/csv/<uuid>/filename.csv to radius/organization/<slug:slug>/batch/<uuid:pk>/csv/filename.csv and added the same in API documentation as well. Fixes openwisp#373
* URL generated with radius:serve_private_file was not consistent with the rest of the API URLs. * Changed Download batch CSV API endpoint from radiusbatch/csv/<uuid>/filename.csv to radius/organization/<slug:slug>/batch/<uuid:pk>/csv/filename.csv and added the same in API documentation as well. Closes openwisp#373
* URL generated with radius:serve_private_file was not consistent with the rest of the API URLs. * Changed Download batch CSV API endpoint from radiusbatch/csv/<uuid>/filename.csv to radius/organization/<slug:slug>/batch/<uuid:pk>/csv/filename.csv and added the same in API documentation as well. Related to #373 Co-authored-by: Dishant Sethi <[email protected]> Co-authored-by: Federico Capoano <[email protected]>
Follow up: 0e76462 fixes the inconsistencies, but the URL is not showing up in the API docs, it would be great it we can add it in some way, for consistency, so I will leave this open. |
The URL generated with
radius:serve_private_file
is not consistent with the rest of the API URLs:Shouldn't this CSV url be as follows?
/api/v1/radius/organization/<slug:slug>/batch/<uuid:pk>/csv/
.We have an inconsistency here, I will create a new issue for this, another problem is that this URL does not show up in the swagger API docs (
/api/v1/docs/
), let's find way to show it there too.This is a follow up of #366 (review).
Further follow up: 0e76462 fixes the inconsistencies, but the URL is not showing up in the API docs, it would be great it we can add it in some way, for consistency, so I will leave this open.
The text was updated successfully, but these errors were encountered: