Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python wrappers break with new material ui #178

Closed
filippomc opened this issue Feb 18, 2020 · 0 comments
Closed

Python wrappers break with new material ui #178

filippomc opened this issue Feb 18, 2020 · 0 comments
Assignees
@filippomc
Labels
bug Something isn't working
Milestone
Release 2.3.0

Comments

@filippomc
Copy link
Contributor

PythonControlledCapability.js the following line breaks with new material-ui components

class PythonControlledComponent extends WrappedComponent {

This is needed to port netpyne to new geppetto-client version @ddelpiano .
@filippomc filippomc added the bug Something isn't working label Feb 18, 2020
@filippomc filippomc self-assigned this Feb 18, 2020
@filippomc filippomc mentioned this issue Feb 18, 2020
Open
filippomc added a commit that referenced this issue Feb 18, 2020
@filippomc
#178 Fixing PythonControlledCapability to work with new Material-ui c…
94ec581 
…omponents
filippomc added a commit that referenced this issue Mar 4, 2020
@filippomc
#178 Fix compatibility with new material-ui
0675696
@filippomc filippomc mentioned this issue Mar 10, 2020
Merged
rodriguez-facundo pushed a commit that referenced this issue Mar 24, 2020
#178 Fix pythonControlledComponent callback oldValue
3a0df4b
rodriguez-facundo pushed a commit that referenced this issue Mar 24, 2020
#178 Eslint fix
ba6cdf1
rodriguez-facundo pushed a commit that referenced this issue Apr 6, 2020
#178 Review requested changes
b33cc1a
filippomc added a commit that referenced this issue Apr 30, 2020
@filippomc
#178 PR chores
0894f9c
tarelli added a commit that referenced this issue May 26, 2020
@tarelli
Merge pull request #196 from openworm/feature/178
6f0f900 
Feature/178: Fix PythonControlledCapability #178
rodriguez-facundo pushed a commit that referenced this issue May 27, 2020
#178 Fix component unmounted when promise is fulfilled
66c1dbd
rodriguez-facundo pushed a commit that referenced this issue May 27, 2020
#178 Linging
229bd97
@filippomc filippomc added this to the Release 2.3.0 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filippomc filippomc

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 2.3.0
Development

No branches or pull requests
1 participant
@filippomc