Fix OSX non-homebrew python install: Added vars to makefile for setting dirs from command-line. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure what would be good variable names, but I tried to follow conventions. I can change them before commiting, if you'd like! |
Closed
|
Hi @NHDaly Thanks! Only wish could you please create pull reques for development branch and I will merge this. |
|
Okay, great! Can I change that now, or do I have to create a new pull request? |
|
Good question:). I'm not sure that is possible to change destination branch in created pull request a simplest way is to create new one:) |
|
haha okay, sounds good! :) |
|
This pull request has been replaced by the above pull request (#31). |
pgleeson
added a commit
that referenced
this pull request
Jul 4, 2022
Improved printing from python helper scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #26, I have made a partial fix to the OSX makefile, by allowing the user to specify python location on the commandline using three new variables: PYTHONLIBDIR, PYTHONHEADERDIR, and PYTHONFRAMEWORKDIR.