Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace HTML5Validator by proof-html #37

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Sep 12, 2024

It seems more popular and maintained.

It seems more popular and maintained.

Signed-off-by: Paul Spooren <[email protected]>
@aparcar
Copy link
Member Author

aparcar commented Sep 12, 2024

@mwarning somehow it doesn't like ||=, any idea why? It seems to be valid...

@mwarning
Copy link
Collaborator

mwarning commented Sep 12, 2024

@mwarning somehow it doesn't like ||=, any idea why? It seems to be valid...

We can replace it with something less niftly:

config.versions = config.versions || upstream_config.versions;
config.default_version = config.default_version || upstream_config.default_version;

or just

if (!config.versions) {
  config.versions = upstream_config.versions;
}

if (!config.default_version) {
  config.default_version = upstream_config.default_version;
}

(this might be more readable anyway..)

@aparcar aparcar force-pushed the proof branch 3 times, most recently from 6c02d17 to 041772b Compare September 12, 2024 14:04
Fix checker errors.

Signed-off-by: Paul Spooren <[email protected]>
Signed-off-by: Paul Spooren <[email protected]>
@aparcar aparcar merged commit 8f47d44 into openwrt:master Sep 12, 2024
@aparcar aparcar deleted the proof branch September 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants