Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node Failed to compile in main branch!!! #17164

Open
zxlhhyccc opened this issue Nov 20, 2021 · 5 comments
Open

node Failed to compile in main branch!!! #17164

zxlhhyccc opened this issue Nov 20, 2021 · 5 comments

Comments

@zxlhhyccc
Copy link

zxlhhyccc commented Nov 20, 2021

image

@1715173329
Copy link
Member

afaict you're using gcc7? if yes please use the latest gcc 11.2 toolchain which is set to default.

@zxlhhyccc
Copy link
Author

afaict you're using gcc7? if yes please use the latest gcc 11.2 toolchain which is set to default.

Gcc7 always compiles node correctly, but not this time!

@1715173329
Copy link
Member

Well, I just forgot that, please see #16729.

nxhack added a commit to nxhack/openwrt that referenced this issue Jan 8, 2022
…chive fd

This fixes the following build error:
/home/build/openwrt/staging_dir/toolchain-aarch64_cortex-a53_gcc-11.2.0_musl/lib/gcc/aarch64-openwrt-linux-musl/11.2.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /home/sergey/openwrt2/build_dir/target-aarch64_cortex-a53_musl/node-v14.18.2/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a: error adding symbols: malformed archive
collect2: error: ld returned 1 exit status

It's a bad error handling related to -EMFILE (too many open files). nodejs is probably just very close to open file limit.

https://sourceware.org/bugzilla/show_bug.cgi?id=28138
nodejs/node#39452

openwrt/packages#17496
openwrt/packages#16729
openwrt/packages#17164

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
jow- pushed a commit to openwrt/openwrt that referenced this issue Jan 8, 2022
…chive fd

This fixes the following build error:
/home/build/openwrt/staging_dir/toolchain-aarch64_cortex-a53_gcc-11.2.0_musl/lib/gcc/aarch64-openwrt-linux-musl/11.2.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /home/sergey/openwrt2/build_dir/target-aarch64_cortex-a53_musl/node-v14.18.2/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a: error adding symbols: malformed archive
collect2: error: ld returned 1 exit status

It's a bad error handling related to -EMFILE (too many open files). nodejs is probably just very close to open file limit.

https://sourceware.org/bugzilla/show_bug.cgi?id=28138
nodejs/node#39452

openwrt/packages#17496
openwrt/packages#16729
openwrt/packages#17164

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
[Take full patch from 2.37 branch and refresh]
Signed-off-by: Hauke Mehrtens <[email protected]>
@nxhack
Copy link
Contributor

nxhack commented Jan 8, 2022

@1715173329 @zxlhhyccc
A patch has been applied to binutils 2.37. Please check it.
openwrt/openwrt@8c501bf

@1715173329
Copy link
Member

Thanks so much!

coolsnowwolf pushed a commit to coolsnowwolf/lede that referenced this issue Jan 10, 2022
* toolchain/binutils: switch to version 2.36.1 by default

Runtime-tested on:
* ath79
* bcm27xx/bcm2708
* bcm27xx/bcm2709
* bcm27xx/bcm2711
* mvebu/cortexa53
* octeon
* realtek
* x86/64

Signed-off-by: Stijn Tintel <[email protected]>
Acked-by: Hauke Mehrtens <[email protected]>

* toolchain/binutils: switch to version 2.37 by default

Compile tests:
* all

Runtime tests:
* ipq806x/generic
* lantiq/mt7621
* lantiq/xrx200
* x86/64

Signed-off-by: Paul Spooren <[email protected]>
Tested-by: Paul Spooren <[email protected]>
Tested-by: Rosen Penev <[email protected]>
Tested-by: Andre Heider <[email protected]>
Tested-by: Ansuel Smith <[email protected]>
Tested-by: Rui Salvaterra <[email protected]>
Signed-off-by: Paul Spooren <[email protected]>

* toolchain/binutils: v2.37 Close the file descriptor if there is no archive fd

This fixes the following build error:
/home/build/openwrt/staging_dir/toolchain-aarch64_cortex-a53_gcc-11.2.0_musl/lib/gcc/aarch64-openwrt-linux-musl/11.2.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /home/sergey/openwrt2/build_dir/target-aarch64_cortex-a53_musl/node-v14.18.2/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a: error adding symbols: malformed archive
collect2: error: ld returned 1 exit status

It's a bad error handling related to -EMFILE (too many open files). nodejs is probably just very close to open file limit.

https://sourceware.org/bugzilla/show_bug.cgi?id=28138
nodejs/node#39452

openwrt/packages#17496
openwrt/packages#16729
openwrt/packages#17164

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
[Take full patch from 2.37 branch and refresh]
Signed-off-by: Hauke Mehrtens <[email protected]>

Co-authored-by: Stijn Tintel <[email protected]>
Co-authored-by: Paul Spooren <[email protected]>
Co-authored-by: Hirokazu MORIKAWA <[email protected]>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this issue Jan 10, 2022
…chive fd

This fixes the following build error:
/home/build/openwrt/staging_dir/toolchain-aarch64_cortex-a53_gcc-11.2.0_musl/lib/gcc/aarch64-openwrt-linux-musl/11.2.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /home/sergey/openwrt2/build_dir/target-aarch64_cortex-a53_musl/node-v14.18.2/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a: error adding symbols: malformed archive
collect2: error: ld returned 1 exit status

It's a bad error handling related to -EMFILE (too many open files). nodejs is probably just very close to open file limit.

https://sourceware.org/bugzilla/show_bug.cgi?id=28138
nodejs/node#39452

openwrt/packages#17496
openwrt/packages#16729
openwrt/packages#17164

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
[Take full patch from 2.37 branch and refresh]
Signed-off-by: Hauke Mehrtens <[email protected]>
Boos4721 pushed a commit to Boos4721/openwrt that referenced this issue Jan 15, 2022
…chive fd

This fixes the following build error:
/home/build/openwrt/staging_dir/toolchain-aarch64_cortex-a53_gcc-11.2.0_musl/lib/gcc/aarch64-openwrt-linux-musl/11.2.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /home/sergey/openwrt2/build_dir/target-aarch64_cortex-a53_musl/node-v14.18.2/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a: error adding symbols: malformed archive
collect2: error: ld returned 1 exit status

It's a bad error handling related to -EMFILE (too many open files). nodejs is probably just very close to open file limit.

https://sourceware.org/bugzilla/show_bug.cgi?id=28138
nodejs/node#39452

openwrt/packages#17496
openwrt/packages#16729
openwrt/packages#17164

Signed-off-by: Hirokazu MORIKAWA <[email protected]>
[Take full patch from 2.37 branch and refresh]
Signed-off-by: Hauke Mehrtens <[email protected]>
Signed-off-by: boos4721 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants