libsodium: Updated to latest version (1.0.11) #3107
Conversation
Signed-off-by: Black Roland <[email protected]>
|
Thanks |
| @@ -52,6 +52,7 @@ endef | |||
|
|
|||
| CONFIGURE_ARGS+= \ | |||
| --disable-ssp \ | |||
| --without-pthreads \ | |||
There was a problem hiding this comment.
Can you explain why disable this?
There was a problem hiding this comment.
Because pthreads does not work with uClibc (OpenWrt CC and low).
There was a problem hiding this comment.
Why not report bugs to uClibc? I don't have such issue using LEDE trunk with musl-libc.
There was a problem hiding this comment.
A pull request for master should not disable features based on limitations in CC. It's meant to be used with LEDE/OpenWrt master.
There was a problem hiding this comment.
@nbd168 What are my next steps? How I can split master and CC versions? Should I create PR for for-15.05 branch?
There was a problem hiding this comment.
You can select target branch when creating pull requests, and check the diff shown below before sending it.
There was a problem hiding this comment.
As I understand CC support limited to bug-fixes and security fixes only. So I made new pull request without CC support.
Maintainer: @damianorenfer
Compile tested: ar71xx OpenWTR DD/CC/BB
Run tested: ar71xx OpenWTR DD (r48648)/CC/BB
Description:
Updated to latest version (1.0.11)