add canonicalize of DynamicReshapeOp.

[linuxlonelyeagle]

No description provided.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[linuxlonelyeagle]

@ghpvnist Can you review the code for me? Or if you have any comments, let me know, I'd love to know what you guys think about this PR.

[linuxlonelyeagle]

I have some questions? If this PR makes sense, do I need to add some files for testing ? If there is one in mlir-hlo, where should I find it. Besides that, the canonicalize addition I refer to mlir-hlo, but now this PR doesn't look elegant, too many files added to add canonicalize, do you have any idea?

[GleasonK]

Thank you for the PR! Could you say more about your use case for StableHLO canonicalization? Does your project depend directly on the StableHLO repo and not on openxla/xla?

The reason I ask, is that currently StableHLO has no canonicalizations, as it is was decided in a previous community discussion that StableHLO is an input dialect and transformations go on MHLO. Personally, I'm in favor of having opt-in StableHLO canonicalization patterns like this in the repo, as it avoids other projects duplicating patterns - for example here are IREE canonicalization patterns for StableHLO which could also be upstreamed and shared among the StableHLO community.

In the current setup, all canonicalization is done on MHLO in xla/mlir_hlo/mhlo/transforms. This assumes that a project depends on XLA, which isn't always the case. Before we submit this change, we'll need to start a discussion on the topic in OpenXLA Discuss to ensure community alignment.

I was hoping to start up a conversation about this exact topic in the coming month, so I'm glad to see this contribution :). Perhaps we can collaborate on that openxla-discuss post!

cc @jpienaar who was also interested in upstreaming some patterns to the repo.

[GleasonK]

Adding blocking review until we establish community precedence for canonicalizations in StableHLO.

[linuxlonelyeagle]

@GleasonK I apologize for being a little late in replying to you, I started a discuss here.

[GleasonK]

Great! Thank you! I'm getting the right people to take a look at it, will report back tomorrow with an update!

[linuxlonelyeagle]

close by #1984.