Update tosa.mul op in StableHLO-to-TOSA Pass in compliance with MLIR upstream and TOSA-v1.0 #2702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the StableHLO to TOSA legalization pass to align with the recent changes in the MLIR upstream. Specifically, the
tosa::MulOp
operation has being modified to comply with the TOSA-v1.0 specification. The shift parameter of the MUL operator, which was previously an attribute, has been moved to an SSA operand.The upstream changes caused a compilation failure in the StableHLO to TOSA conversion pass because the
tosa.mul
operation now expects 3 operand groups instead of 2, as reflected in the error message:This PR added a zero constant as the additional argument for the shift parameter to maintain compatibility with the updated
tosa.mul
operation.