-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interpreter for DotGeneralOp #748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
January 8, 2023 08:29
12a9f55
to
3b009b8
Compare
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
February 7, 2023 06:39
3b009b8
to
1d58458
Compare
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
February 7, 2023 06:43
1d58458
to
1fbd315
Compare
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
February 7, 2023 19:40
1fbd315
to
76185f8
Compare
sdasgup3
reviewed
Feb 10, 2023
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
February 15, 2023 00:43
76185f8
to
901de0f
Compare
ghpvnist
force-pushed
the
dot_general_interpreter
branch
2 times, most recently
from
March 24, 2023 23:30
406b8f3
to
99522d1
Compare
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
April 5, 2023 17:32
99522d1
to
f81b418
Compare
This is not a reference implementation to the spec, but decided to keep it as the reference implementation requires reliance on MLIR builders (to create ReduceOp) which affects readability. Thoughts? @burmako |
Happy to review as is, and then let's discuss that as part of the review? |
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
April 21, 2023 00:13
f81b418
to
baa1dd8
Compare
burmako
suggested changes
May 29, 2023
ghpvnist
force-pushed
the
dot_general_interpreter
branch
2 times, most recently
from
May 31, 2023 22:03
1dfff45
to
072ea54
Compare
burmako
suggested changes
Jun 3, 2023
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
June 7, 2023 22:58
072ea54
to
361eb59
Compare
burmako
suggested changes
Jun 8, 2023
burmako
approved these changes
Jun 9, 2023
ghpvnist
force-pushed
the
dot_general_interpreter
branch
from
June 9, 2023 17:42
b99c8bc
to
0b21091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the following non-quantization-related constraints (excluding C13, C15-C20) in the spec:
These constraints will be comprehensively covered by the following tests:
If we drop the "Covered by ODS" pieces, this will leave us with the following test cases:
Notes:
closes #336