Add generalization for DotLike operations #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an `allocShape` field to denote the shape a memory descriptor when it's allocated. The value will be propagated to all its descendants created through `subview` ops. - Make `encoding` and `memorySpace` fields required instead of optional. - Implement the `getAlias` function for `#ttg.shared_memory` to shorten its length in `.mlir` files
karupayun
force-pushed
the
refactor/generalize-dot-like-op
branch
from
d6117aa to
51e2597
Compare
This commit is to support atomic_rmw in the function predicateOp to mask operations during scheduling.
PR triton-lang#5231 was authored before the `triton_gpu` -> `ttg` rename and CI is currently broken.
…riton-lang#5314) For other backends, `ptxas` may not be installed. Signed-off-by: Anatoly Myachev <[email protected]>
This pulls in the AMDGPU backend support for the gfx950 target. We need to fix the rewrites in `Combine.td` given that llvm/llvm-project#112700 adds a new attribute for denorm mode for `arith.addf`. --------- Co-authored-by: Lei Zhang <[email protected]>
Enable new arch target since backend support has been added.
chsigg
approved these changes
Dec 4, 2024
karupayun
force-pushed
the
refactor/generalize-dot-like-op
branch
from
51e2597 to
98a9664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows other dot-like operations to be built on top of Triton instead of requiring ops to be
DotOpexactly.We are using this internally in order to support SparseDotOp (which has DotLike trait implemented).