Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]NodePool Governance Capability: Add admission webhook #775

Closed
Peeknut opened this issue Mar 10, 2022 · 7 comments · Fixed by #1040
Closed

[feature request]NodePool Governance Capability: Add admission webhook #775

Peeknut opened this issue Mar 10, 2022 · 7 comments · Fixed by #1040
Assignees
Labels

Comments

@Peeknut
Copy link
Member

Peeknut commented Mar 10, 2022

What would you like to be added:
Admission webhook ensures the feature of Node Autonomy and NodePool Autonomy that have been described in #776

  • node autonomy: when workload has annotated with node autonomy, tolerations for tolerating node notReady will be added to pods automatically.
  • if certain percent(default value: 70%) of nodes status in NodePool are marked as notReady or un-schedulable, pods will be prevented to evict in nodepool, because not enough nodes in NodePool have resource to take pods.

Why is this needed:
For details, please refer to the proposal: #772

others
/kind feature

@Peeknut Peeknut added the kind/feature kind/feature label Mar 10, 2022
@gnunu
Copy link
Member

gnunu commented Mar 11, 2022

/assign @LindaYu17

@LindaYu17
Copy link
Member

webhook development complete, waiting for integration with other components.
add two validating webhook:

  1. poolcoordiantor-webhook: validate pool-coordinator CR create/update
  2. nodeautonomy-webhook: validate when annotating node as node autonomy

@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 31, 2022
@rambohe-ch
Copy link
Member

/pinned

1 similar comment
@rambohe-ch
Copy link
Member

/pinned

@rambohe-ch
Copy link
Member

/close

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from In Progress to Done in controlplane-v1.2 Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants