Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zed: Cut down log spam on disk events #15086

Closed
tonyhutter opened this issue Jul 20, 2023 · 0 comments
Closed

zed: Cut down log spam on disk events #15086

tonyhutter opened this issue Jul 20, 2023 · 0 comments
Assignees
@tonyhutter
Labels
Component: ZED ZFS Event Daemon Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@tonyhutter
Copy link
Contributor

System information

Type Version/Name
Distribution Name
Distribution Version
Kernel Version
Architecture
OpenZFS Version

Describe the problem you're observing

ZED can be incredibly chatty, especially on large JBODs:

zed[534281]: zfs_iter_pool: evaluating vdevs on merced101 (by path)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L0)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L2)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L4)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L6)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L8)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L10)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L12)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L14)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L16)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L18)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L20)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L22)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L24)
zed[534281]:   zfs_iter_vdev: no match (/dev/disk/by-vdev/U4 != vdev /dev/disk/by-vdev/L26)
...

Simply getting rid of the zfs_iter_vdev: no match lines will cut logs by at least half.

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs
@tonyhutter tonyhutter added the Type: Defect Incorrect behavior (e.g. crash, hang) label Jul 20, 2023
@tonyhutter tonyhutter self-assigned this Jul 20, 2023
@behlendorf behlendorf added the Component: ZED ZFS Event Daemon label Jul 20, 2023
behlendorf added a commit to behlendorf/zfs that referenced this issue Jul 21, 2023
@behlendorf
zed: Reduce log noise for large JBODs
dcc296a 
For large JBODs the log message "zfs_iter_vdev: no match" can
account for the bulk of the log messages (over 70%).  Since this
message is purely informational and not that useful we remove it.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#15086
@behlendorf behlendorf mentioned this issue Jul 21, 2023
Merged
13 tasks
behlendorf added a commit to behlendorf/zfs that referenced this issue Jul 25, 2023
@behlendorf
zed: Reduce log noise for large JBODs
f22a4bb 
For large JBODs the log message "zfs_iter_vdev: no match" can
account for the bulk of the log messages (over 70%).  Since this
message is purely informational and not that useful we remove it.

Reviewed-by: Olaf Faaland <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15086
Closes openzfs#15094
behlendorf added a commit to behlendorf/zfs that referenced this issue Jul 25, 2023
@behlendorf
zed: Reduce log noise for large JBODs
5328973 
For large JBODs the log message "zfs_iter_vdev: no match" can
account for the bulk of the log messages (over 70%).  Since this
message is purely informational and not that useful we remove it.

Reviewed-by: Olaf Faaland <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15086
Closes openzfs#15094
behlendorf added a commit that referenced this issue Jul 26, 2023
@behlendorf
zed: Reduce log noise for large JBODs
1abf68b 
For large JBODs the log message "zfs_iter_vdev: no match" can
account for the bulk of the log messages (over 70%).  Since this
message is purely informational and not that useful we remove it.

Reviewed-by: Olaf Faaland <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #15086
Closes #15094
behlendorf added a commit that referenced this issue Jul 26, 2023
@behlendorf
zed: Reduce log noise for large JBODs
b9aa32f 
For large JBODs the log message "zfs_iter_vdev: no match" can
account for the bulk of the log messages (over 70%).  Since this
message is purely informational and not that useful we remove it.

Reviewed-by: Olaf Faaland <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #15086
Closes #15094
ofaaland pushed a commit to LLNL/zfs that referenced this issue Aug 29, 2023
@behlendorf @defaziogiancarlo
zed: Reduce log noise for large JBODs
4638eb2 
For large JBODs the log message "zfs_iter_vdev: no match" can
account for the bulk of the log messages (over 70%).  Since this
message is purely informational and not that useful we remove it.

Reviewed-by: Olaf Faaland <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15086
Closes openzfs#15094
Signed-off-by: Gian-Carlo DeFazio <[email protected]>
(cherry picked from commit 782312c)
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Dec 12, 2023
@behlendorf @lundman
zed: Reduce log noise for large JBODs
e46a520 
For large JBODs the log message "zfs_iter_vdev: no match" can
account for the bulk of the log messages (over 70%).  Since this
message is purely informational and not that useful we remove it.

Reviewed-by: Olaf Faaland <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15086
Closes openzfs#15094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyhutter tonyhutter

Labels
Component: ZED ZFS Event Daemon Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behlendorf @tonyhutter