Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Wait for free space between quota tests #10146

Merged
merged 1 commit into from
Mar 26, 2020
Merged

ZTS: Wait for free space between quota tests #10146

merged 1 commit into from
Mar 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2020

And in removal tests, sync the specific pool we are waiting on.

Motivation and Context

Tests that exhaust free space can have side effects on later tests as the free space reclamation occurs in the background.

Description

Use wait_freeing and sync_pool in cleanup for quota tests, instead of sleep 5.
And in removal tests, sync the specific pool we are waiting on.

How Has This Been Tested?

ZTS on FreeBSD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

ZTS: Wait for free space between quota tests
dd10d48 
And in removal tests, sync the specific pool we are waiting on.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Mar 20, 2020
@ghost ghost requested a review from jwk404 March 20, 2020 16:23
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 20, 2020
@behlendorf behlendorf merged commit ef3331e into openzfs:master Mar 26, 2020
@ghost ghost deleted the zts-freeing-syncing branch March 26, 2020 17:48
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
ZTS: Wait for free space between quota tests
87af11b 
And in removal tests, sync the specific pool we are waiting on.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#10146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @jwk404