Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude zvol_misc_volmode for now #12733

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Exclude zvol_misc_volmode for now #12733

merged 1 commit into from
Nov 9, 2021

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

It keeps failing, on changes which aren't related at all.

So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.

Description

It's an exclude.

How Has This Been Tested?

Not at all.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@rincebrain
Exclude zvol_misc_volmode for now
154c8fb 
It keeps failing, on changes which aren't related at all.

So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.

Signed-off-by: Rich Ercolani <[email protected]>
@jwk404 jwk404 self-assigned this Nov 8, 2021
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Nov 8, 2021
@jwk404 jwk404 merged commit 380b072 into openzfs:master Nov 9, 2021
pcd1193182 pushed a commit to pcd1193182/zfs that referenced this pull request Nov 12, 2021
@rincebrain @pcd1193182
Exclude zvol_misc_volmode for now
f39b975 
It keeps failing, on changes which aren't related at all.

So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12733
@jgottula
Copy link
Contributor

jgottula commented Dec 2, 2021

@rincebrain Is it possible that this may have been related to udev occasionally randomly failing to create the zvol dev node symlinks properly because of lock contention during zvol open (#12301)? Skimming the test file in question here suggests to me it could have been.

If so, then the failures might not happen anymore, now that #12759 is merged.

(If you already ruled out #12301 having anything to do with this, then disregard.)

@rincebrain
Copy link
Contributor Author

Certainly seems possible. I haven't revisited it since that landed, and I don't know that I'll doso in the near term, just because my time is rather spoken for for the next week at least. Feel free to revert this in a branch and test it yourself. :)

@behlendorf
Copy link
Contributor

This is pretty likely, I believe we should be able to revert this.

tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@rincebrain @tonyhutter
Exclude zvol_misc_volmode for now
f3d4497 
It keeps failing, on changes which aren't related at all.

So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12733
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 14, 2022
@rincebrain @tonyhutter
Exclude zvol_misc_volmode for now
0c92887 
It keeps failing, on changes which aren't related at all.

So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12733
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 16, 2022
@rincebrain @tonyhutter
Exclude zvol_misc_volmode for now
2edb4c3 
It keeps failing, on changes which aren't related at all.

So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12733
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 17, 2022
@rincebrain @tonyhutter
Exclude zvol_misc_volmode for now
4730c3f 
It keeps failing, on changes which aren't related at all.

So until someone runs down why, I'd like it to stop being the
sole reason for CI failures.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12733
@robn robn mentioned this pull request Jul 19, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@jwk404 jwk404 jwk404 approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees

@jwk404 jwk404

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rincebrain @jgottula @behlendorf @jwk404 @gmelikov