Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux PPC: Fix build failures on kernels built without CONFIG_SPE #14244

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Linux PPC: Fix build failures on kernels built without CONFIG_SPE #14244

merged 1 commit into from
Dec 9, 2022

Conversation

ryao
Copy link
Contributor

@ryao ryao commented Dec 1, 2022

Motivation and Context

@rincebrain reported in #14233 that builds were broken on recent kernels without CONFIG_SPE.

Description

We do a simple ifdef to avoid calling enable_kernel_spe()/disable_kernel_spe() on PowerPC.

How Has This Been Tested?

@gyakovlev tested it for me.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ryao
Linux PPC: Fix build failures on kernels built without CONFIG_SPE
d458f20 
Closes openzfs#14233
Reported-by: Rich Ercolani <[email protected]>
Tested-by: Georgy Yakovlev <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
@ryao ryao changed the title PowerPC: Fix build failures on kernels built without CONFIG_SPE Linux PPC: Fix build failures on kernels built without CONFIG_SPE Dec 1, 2022
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 9, 2022
@behlendorf behlendorf merged commit 5401472 into openzfs:master Dec 9, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 16, 2022
@ryao @andrewc12
Linux PPC: Fix build failures on kernels built without CONFIG_SPE
e468399 
We do a simple ifdef to avoid calling enable_kernel_spe()/
disable_kernel_spe() on PowerPC.

Reported-by: Rich Ercolani <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Tested-by: Georgy Yakovlev <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#14233
Closes openzfs#14244
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 17, 2022
@ryao @andrewc12
Linux PPC: Fix build failures on kernels built without CONFIG_SPE
f759c48 
We do a simple ifdef to avoid calling enable_kernel_spe()/
disable_kernel_spe() on PowerPC.

Reported-by: Rich Ercolani <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Tested-by: Georgy Yakovlev <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#14233
Closes openzfs#14244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmilk mcmilk mcmilk approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryao @behlendorf @mcmilk