Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for btree implementation used by range trees #9717

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Tests for btree implementation used by range trees #9717

merged 1 commit into from
Dec 19, 2019

Conversation

jwk404
Copy link
Contributor

@jwk404 jwk404 commented Dec 12, 2019

Signed-off-by: John Kennedy [email protected]

Motivation and Context

These are tests for the recently added btree implementation.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #9717 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #9717    +/-   ##
========================================
+ Coverage      79%      80%   +<1%     
========================================
  Files         385      385            
  Lines      121299   121299            
========================================
+ Hits        96407    96453    +46     
+ Misses      24892    24846    -46
Flag Coverage Δ
#kernel 80% <ø> (ø) ⬆️
#user 67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118fc3e...8e3f115. Read the comment docs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 13, 2019
@jwk404
Copy link
Contributor Author

jwk404 commented Dec 13, 2019

Looking at the build failures and core dump.

@jwk404
Copy link
Contributor Author

jwk404 commented Dec 18, 2019

  • use the TREE_CMP macro
  • unconditionally enable ASSERTS
  • added comments
  • changes some types for compilation errors

@jwk404 jwk404 requested a review from pcd1193182 December 19, 2019 15:30
@behlendorf behlendorf merged commit 523fc80 into openzfs:master Dec 19, 2019
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 19, 2019
@jwk404 jwk404 deleted the btree branch December 19, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants