Unify target_cpu handling #9848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
force-pushed
the
arch-unify
branch
from
4581786 to
fe534d1
Compare
behlendorf
force-pushed
the
arch-unify
branch
from
fe534d1 to
42343ee
Compare
|
@freqlabs would you mind taking a look at this to verify it'll work with the FreeBSD changes. |
behlendorf
added
Status: Code Review Needed
ghost
reviewed
Jan 16, 2020
| # Suppress unused but set variable warnings often due to ASSERTs | ||
| ccflags-y += $(NO_UNUSED_BUT_SET_VARIABLE) | ||
|
|
||
| # Suppress unused-value warnings in sparc64 architecture headers |
There was a problem hiding this comment.
See also:
module/zcommon/Makefile.in
module/os/linux/zfs/Makefile.in
ghost
approved these changes
Jan 16, 2020
Over the years several slightly different approachs were used in the Makefiles to determine the target architecture. This change updates both the build system and Makefile to handle this in a consistent fashion. TARGET_CPU is set to i386, x86_64, powerpc, aarch6 or sparc64 and made available in the Makefiles to be used as appropriate. Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf
force-pushed
the
arch-unify
branch
from
42343ee to
57d7c5b
Compare
|
Refreshed to update |
Codecov Report
@@ Coverage Diff @@
## master #9848 +/- ##
========================================
+ Coverage 79% 80% +<1%
========================================
Files 385 385
Lines 121644 121644
========================================
+ Hits 96587 96849 +262
+ Misses 25057 24795 -262
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Over the years several slightly different approaches were used in the Makefiles to determine the target architecture. This change updates both the build system and Makefile to handle this in a consistent fashion. TARGET_CPU is set to i386, x86_64, powerpc, aarch6 or sparc64 and made available in the Makefiles to be used as appropriate. Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#9848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolve some technical dept which makes detecting the target
architecture for conditional Makefiles overly difficult.
Description
Over the years several slightly different approaches were used
in the Makefiles to determine the target architecture. This
change updates both the build system and Makefile to handle
this in a consistent fashion.
TARGET_CPU is set to i386, x86_64, powerpc, aarch6 or sparc64
and made available in the Makefiles to be used as appropriate.
How Has This Been Tested?
Test built on x86_64 and ppc64. Pending CI build testing for arm,
aarch64, ppc, and i386.
Types of changes
Checklist:
Signed-off-by.