Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikivoyage landing page links crash application #852

Closed
Popolechien opened this issue Jun 28, 2019 · 4 comments
Closed

Wikivoyage landing page links crash application #852

Popolechien opened this issue Jun 28, 2019 · 4 comments
Assignees
Labels

Comments

@Popolechien
Copy link

Popolechien commented Jun 28, 2019

Following up on /openzim/zimfarm/issues/257

Clicking on any link on this landing page will cause the application to crash on macOS, or lead to a blank page on Android.

On Android I seem to be able to search for and access articles, but not on macOS/iOS (this was initially reported by an iOS user).

See also #794

@kelson42
Copy link
Collaborator

kelson42 commented Jun 29, 2019

If we have a crash, this is a bug by the reader. But we might have a problem here too.

@kelson42 kelson42 self-assigned this Jun 29, 2019
@kelson42 kelson42 added this to the 1.9-maintenance milestone Jun 29, 2019
@kelson42
Copy link
Collaborator

@Popolechien Please open one ticket for one problem, I have created #157 for the crash on MacOS. The root problem (of missing article in the ZIM) has been fixed in #726.

@Jaifroid
Copy link
Collaborator

Jaifroid commented Jul 15, 2019

I just want to add that this issue probably is related to the fact that the hyperlinks on the landing page of wikivoyage_en_all_novid_2019-06.zim are incorrect. The landing page's URL is:

Wikivoyage%3AOffline_reader_Expedition/Home_page

(note the forward slash). However, hyperlinks on the page are:

<a title="Europe" href="Europe">Europe</a>

That's clearly incorrect, as the href should be ../Europe. This should have been fixed in mwoffliner kiwix/kiwix-js#498. I'm not sure kiwix/kiwix-apple#157 should "fix" what is an error in the ZIM.

@kelson42
Copy link
Collaborator

kelson42 commented Jul 15, 2019

@Jaifroid Thank you for insisting, this is still not working fine on MWoffliner side. I have reopen #726. Really sorry for this never ending story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants