Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix MacOS always crash by trying to open an non-existing article #157

Closed
kelson42 opened this issue Jun 29, 2019 · 10 comments
Closed

Kiwix MacOS always crash by trying to open an non-existing article #157

kelson42 opened this issue Jun 29, 2019 · 10 comments

Comments

@kelson42
Copy link
Contributor

Steps:
1 - Download http://tmp.kiwix.org/wikivoyage_en_all_novid_2019-06.zim
2 - Open main page
3 - Click on "Europe"

You get:
1 - Application quits

You should get:
1 - An empty page or an error

Remark
Link "Europe" points to an non-existing article, this is the root of the bug probably...

@Jaifroid
Copy link
Member

Jaifroid commented Jul 15, 2019

(This is a copy of openzim/mwoffliner#852 (comment) ) This issue probably is related to the fact that the hyperlinks on the landing page of wikivoyage_en_all_novid_2019-06.zim are incorrect. The landing page's URL is:

Wikivoyage%3AOffline_reader_Expedition/Home_page

(note the forward slash). However, hyperlinks on the page are:

<a title="Europe" href="Europe">Europe</a>

That's clearly incorrect, as the href should be ../Europe. This should have been fixed in mwoffliner kiwix/kiwix-js#498. I'm not sure #157 should "fix" what is an error in the ZIM.

@kelson42 kelson42 changed the title Kiwix MacOS alwasy crash by trying to open an non-existing article Kiwix MacOS always crash by trying to open an non-existing article Jul 15, 2019
@kelson42 kelson42 pinned this issue Jul 30, 2019
@automactic automactic unpinned this issue Aug 15, 2019
@jhbiggs
Copy link

jhbiggs commented Aug 25, 2019

Is this issue current? Do I need a paid Apple Developer license to build this app via Xcode? My first attempt failed because of a missing provisioning profile for WikiMed.

@Jaifroid
Copy link
Member

@jhbiggs I would say this issue is still current until openzim/mwoffliner#726 is fully resolved. I don't know about your other questions.

@kelson42
Copy link
Contributor Author

@jhbiggs Yes, I confirm.

@stale
Copy link

stale bot commented Oct 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@automactic
Copy link
Member

@kelson42 Do you happen to have a zim file available to test this issue? If not, I am gonna close this as unable to reproduce

@stale stale bot removed the stale label Aug 15, 2020
@kelson42
Copy link
Contributor Author

@automactic It seems to not crash anymore indeed. That said, no info/erro is printed either.

@automactic
Copy link
Member

That said, no info/erro is printed either.

You mean when click on an article that does not exist? Do you have an example zim file that could be used as test? I have recently added a alert for this scenario on iOS could certainly do the same for macOS

@kelson42
Copy link
Contributor Author

@automactic the current edutech fr has a lot of them.

@automactic
Copy link
Member

added alert in #308

Screen Shot 2020-08-16 at 12 01 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants